Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before and after build steps for code climate that handle parallelism #5

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cjcolvar
Copy link
Member

No description provided.

@cjcolvar cjcolvar force-pushed the codeclimate branch 2 times, most recently from 4916f34 to 299e382 Compare April 2, 2019 20:13
@rotated8
Copy link
Contributor

@cjcolvar Any updates on this? I'd love to use it.

@cjcolvar
Copy link
Member Author

@rotated8 Sorry this fell off my radar.
It is a little bit tricky since I think it requires an additional workflow job to submit the results compiled from the different parallel runs. Here is what it looks like in our circle config outside of the orb commands: https://github.com/avalonmediasystem/avalon/blob/master/.circleci/config.yml#L86-L128
Would you like to try and finish off this PR? Or we could try to work together on it.

@rotated8
Copy link
Contributor

@cjcolvar No worries, I can try working on it, although I expect it'll be slow going, based on the other things I need to get done.

@cjcolvar
Copy link
Member Author

@rotated8 I see you're looking at this again. Looking over how avalon does it, I wonder if the before should include the persist_to_workspace and the after should actually be turned into a full job that could probably use the simplest slim container that code climate's scripts can run on.

@rotated8
Copy link
Contributor

@cjcolvar Oh yeah, I like that suggestion. I'll keep it in mind as I work on this.

@cjcolvar
Copy link
Member Author

cjcolvar commented Jul 9, 2020

As another data point, I just added this to a new repo: ubiquitypress/hyku_addons@5fafa49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants